feat: update borsh-js to v1.0.0 #1168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have been working on a new version of borsh-js, this commit updates all the files that depend on borsh-js. This update is a breaking change, since the objects schemas (which are exported) are completely different from v0.7.0 (before) to v1.0.1 (now). The main benefit of updating borsh-js is that the new version is agnostic to the class being serialized, meaning that two "deep-equal" instances of different classes can be serialized using the same Schema. This means that near-api-js will be able to (de)serialize objects created across different library versions (which currently is not possible).
🦋 Changeset detectedLatest commit: 54f6708 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The new version of Borsh has been released without the `baseDecode` and `baseEncode` methods. I have migrated these methods as they were from `borsh` to the `near-api-js/utils/format` package.
gagdiez
changed the title
|
@andy-haynes this PR is ready to be reviewed. The most important thing to take into account is that the new version of |
Merged
This was referenced Nov 30, 2023
frol
reviewed
Dec 18, 2023
Comment on lines
+2
to
+7
| "near-api-js": major | ||
| "@near-js/accounts": major | ||
| "@near-js/biometric-ed25519": major | ||
| "@near-js/crypto": major | ||
| "@near-js/transactions": major | ||
| "@near-js/wallet-account": major |
There was a problem hiding this comment.
@gagdiez This caused packages to be released as 1.0.0 release instead of 0.x 😐
I just wanted to mention it for future reference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
pnpm changesetto create achangesetJSON document appropriate for this change.Motivation
We have developed a new version of
borsh-jswhich is agnostic to theClassbeing (de)serialized. This means that two "deep equal" objects can be (de)Serialized using the same Schema, no matter their origin or particular Class.Test Plan
I have updated the dependency of
borsh-jsand changed the code as minimal as possible until all the tests passed again.Related issues/PRs
Fixes #1167