Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry RPC requests on 408 HTTP error #1205

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Retry RPC requests on 408 HTTP error #1205

merged 2 commits into from
Nov 28, 2023

Conversation

denbite
Copy link
Contributor

@denbite denbite commented Nov 21, 2023

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • Commit messages follow the conventional commits spec
  • If this is a code change: I have written unit tests.
  • If this changes code in a published package: I have run pnpm changeset to create a changeset JSON document appropriate for this change.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Non-mainnet networks may experience instability and return 408 HTTP errors, which could delay testing/development. However, this can be fixed by retrying requests.

Test Plan

Related issues/PRs

made #989 working without merge conflicts by minor code change

Copy link

changeset-bot bot commented Nov 21, 2023

🦋 Changeset detected

Latest commit: fe5b740

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@near-js/providers Patch
@near-js/accounts Patch
@near-js/cookbook Patch
near-api-js Patch
@near-js/wallet-account Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@denbite denbite mentioned this pull request Nov 21, 2023
5 tasks
Copy link
Collaborator

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you!

@frol frol merged commit 0be6c42 into near:master Nov 28, 2023
3 checks passed
denbite added a commit to denbite/near-api-js that referenced this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants