Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs #1274

Merged
merged 3 commits into from
Jan 22, 2024
Merged

Update docs #1274

merged 3 commits into from
Jan 22, 2024

Conversation

gtsonevv
Copy link
Collaborator

@gtsonevv gtsonevv commented Jan 18, 2024 •
edited
Loading

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • Commit messages follow the conventional commits spec
  • If this is a code change: I have written unit tests.
  • If this changes code in a published package: I have run pnpm changeset to create a changeset JSON document appropriate for this change.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Test Plan

Related issues/PRs

@gtsonevv gtsonevv requested a review from vikinatora January 18, 2024 12:43
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 18, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 7f437e3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vikinatora
vikinatora reviewed Jan 19, 2024
View reviewed changes
Copy link
Collaborator

@vikinatora vikinatora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicks

packages/accounts/src/account_2fa.ts Outdated Show resolved Hide resolved
packages/accounts/src/account_2fa.ts Outdated Show resolved Hide resolved
packages/biometric-ed25519/src/index.ts Outdated Show resolved Hide resolved
packages/transactions/src/action_creators.ts Outdated Show resolved Hide resolved
packages/transactions/src/action_creators.ts Outdated Show resolved Hide resolved
packages/transactions/src/schema.ts Outdated Show resolved Hide resolved
packages/wallet-account/src/wallet_account.ts Outdated Show resolved Hide resolved
vikinatora
vikinatora approved these changes Jan 19, 2024
View reviewed changes
Copy link
Collaborator

@vikinatora vikinatora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gtsonevv gtsonevv merged commit ae9600b into near:master Jan 22, 2024
1 check passed
@gtsonevv gtsonevv deleted the update-docs branch January 22, 2024 12:29
@vikinatora vikinatora mentioned this pull request Jan 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikinatora vikinatora vikinatora approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gtsonevv @vikinatora