-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update RPC error schema update process #1364
Conversation
This commit updates the README description for how to update to a new RPC error schema. I also delete two files in near-api-js which seem to be unused. The source of truth, as far as I can tell, is in the utils package now.
|
@race-of-sloths please, include my PR in the race |
@jakmeier Thank you for your contribution! Your pull request is now a part of the Race of Sloths! Current status: executed
Your contribution is much appreciated with a final score of 2! Another weekly streak completed, well done @jakmeier! To keep your weekly streak and get another bonus make pull request next week! Looking forward to see you in race-of-sloths What is the Race of SlothsRace of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow For contributors:
For maintainers:
Feel free to check our website for additional details! Bot commands
|
@race-of-sloths score 2 |
This commit updates the README description for how to update to a new RPC error schema.
I also delete two files in near-api-js which seem to be unused. The source of truth, as far as I can tell, is in the utils package now.
Pre-flight checklist
pnpm changeset
to create achangeset
JSON document appropriate for this change.Motivation
I got confused as to how to update the generated files since the README is outdated and it's unclear how to update these files. But since I couldn't find out where they are used, the code only references the files in the utils package. I assume the other files are left over from previous code structures and should rather be deleted to clean things up.
Test Plan
Related issues/PRs
Related: #1358