-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support non-200 RPC error #1404
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
d821783
fix: support non-200 RPC error
19Nazar 47aa671
Merge pull request #1 from 19Nazar/add_handler_request
19Nazar ddfa910
Merge branch 'master' into master
19Nazar cd0c6f1
Merge branch 'master' into master
19Nazar d203d42
test: add test fetch_json_error.test.ts, add: 503 handler
19Nazar e9332ef
Merge branch 'master' into master
19Nazar 6bed74a
Merge branch 'master' into master
19Nazar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,74 @@ | ||
import { describe, expect, test, jest, afterEach } from '@jest/globals'; | ||
import { fetchJsonRpc } from '../src/fetch_json'; | ||
import unfetch from 'isomorphic-unfetch'; | ||
import { ProviderError } from '../src/fetch_json'; | ||
|
||
jest.mock('isomorphic-unfetch'); | ||
|
||
describe('fetchJsonError', () => { | ||
const RPC_URL = 'https://rpc.testnet.near.org'; | ||
const statusRequest = { | ||
jsonrpc: '2.0', | ||
id: 'dontcare', | ||
method: 'status', | ||
params: [], | ||
}; | ||
|
||
afterEach(() => { | ||
jest.clearAllMocks(); | ||
}); | ||
|
||
test('handles 500 Internal Server Error', async () => { | ||
(unfetch as jest.Mock).mockReturnValue({ | ||
ok: false, | ||
status: 500, | ||
text: '', | ||
json: {}, | ||
}); | ||
|
||
// @ts-expect-error test input | ||
await expect(fetchJsonRpc(RPC_URL, statusRequest, undefined)) | ||
.rejects | ||
.toThrowError(new ProviderError('Internal server error', { cause: 500 })); | ||
}); | ||
test('handles 408 Timeout Error', async () => { | ||
(unfetch as jest.Mock).mockReturnValue({ | ||
ok: false, | ||
status: 408, | ||
text: '', | ||
json: {}, | ||
}); | ||
// @ts-expect-error test input | ||
await expect(fetchJsonRpc(RPC_URL, statusRequest, undefined)) | ||
.rejects | ||
.toThrowError(new ProviderError('Timeout error', { cause: 408 })); | ||
}); | ||
// }); | ||
|
||
test('handles 400 Request Validation Error', async () => { | ||
(unfetch as jest.Mock).mockReturnValue({ | ||
ok: false, | ||
status: 400, | ||
text: '', | ||
json: {}, | ||
}); | ||
// @ts-expect-error test input | ||
await expect(fetchJsonRpc(RPC_URL, statusRequest, undefined)) | ||
.rejects | ||
.toThrowError(new ProviderError('Request validation error', { cause: 400 })); | ||
}); | ||
|
||
test('handles 503 Service Unavailable', async () => { | ||
(unfetch as jest.Mock).mockReturnValue({ | ||
ok: false, | ||
status: 503, | ||
text: '', | ||
json: {}, | ||
}); | ||
|
||
// @ts-expect-error test input | ||
await expect(fetchJsonRpc(RPC_URL, statusRequest, undefined)) | ||
.rejects | ||
.toThrowError(new ProviderError(`${RPC_URL} unavailable`, { cause: 503 })); | ||
}); | ||
}); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the reason for removing
503
error? It is still the case as I see in thenearcore
code. It should be retried as well