Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wal 338 abstractions if using js sdk #870

Merged
merged 5 commits into from
Jun 8, 2022
Merged

Wal 338 abstractions if using js sdk #870

merged 5 commits into from
Jun 8, 2022

Conversation

gutsyphilip
Copy link
Contributor

Closes #867

In this PR:

  • Adds support for passing a jsContract boolean to the functionCall payload which indicates that the call came from the JS SDK. Hence, args gets encoded accordingly.

@gutsyphilip gutsyphilip requested a review from vgrichina as a code owner June 3, 2022 16:32
BenKurrek
BenKurrek suggested changes Jun 6, 2022
View reviewed changes
lib/account.js Outdated Show resolved Hide resolved
lib/account.js Outdated Show resolved Hide resolved
lib/account.js Outdated Show resolved Hide resolved
src/account.ts Outdated Show resolved Hide resolved
@thisisjoshford thisisjoshford mentioned this pull request Jun 7, 2022
Merged
agileurbanite
agileurbanite approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@agileurbanite agileurbanite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agileurbanite agileurbanite removed the request for review from vgrichina June 8, 2022 15:58
esaminu
esaminu reviewed Jun 8, 2022
View reviewed changes
src/account.ts Outdated Show resolved Hide resolved
@gutsyphilip gutsyphilip merged commit c158218 into master Jun 8, 2022
@gutsyphilip gutsyphilip deleted the WAL-338-abstractions-if-using-js-sdk branch June 8, 2022 17:30
@SherfeyInv SherfeyInv mentioned this pull request May 24, 2024
Merged
@LasaKaru LasaKaru mentioned this pull request Aug 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esaminu esaminu esaminu left review comments

@agileurbanite agileurbanite agileurbanite approved these changes

@BenKurrek BenKurrek BenKurrek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Abstractions If Using JS SDK
4 participants
@gutsyphilip @agileurbanite @esaminu @BenKurrek