Secp256k1 support PR rebased #985
Conversation
esaminu
force-pushed
the
secp256k1-support-rebased
branch
from
50ee50d to
5d46883
Compare
🦋 Changeset detectedLatest commit: 018fe99 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -68,7 +69,7 @@ | |||
| "files": [ | |||
| { | |||
| "path": "dist/near-api-js.min.js", | |||
| "maxSize": "105kB" | |||
| "maxSize": "250kB" | |||
There was a problem hiding this comment.
This seems like a very big jump, is this really necessary? Do you know what size we're at currently?
There was a problem hiding this comment.
We went from 68.23KB in current master to 174.92KB which is a big jump due to the secp256k1 dependency https://bundlephobia.com/package/secp256k1@4.0.3
@MaximusHaximus thoughts on how if at all this affects how we release this?
|
We'll also need a |
|
Sorry misclick |
esaminu
force-pushed
the
secp256k1-support-rebased
branch
from
5d46883 to
51936fc
Compare
Co-authored-by: Morgan McCauley <morgan@mccauley.co.nz>
esaminu
force-pushed
the
secp256k1-support-rebased
branch
from
6648797 to
4e5c8cd
Compare
| "near-api-js": minor | ||
| --- | ||
|
|
||
| Add support for the secp256k1 curve |
There was a problem hiding this comment.
It would be good to add more detail here, can we please expand on this? Maybe something along the lines of: "Add support for generating secp256k1 key pairs for signing and verification of messages". Not super familiar with the changes so maybe there is more.
|
we will need this also |
|
Hey @frol, if this PR is ready to merge, we can create a new one and move the changes there again. |
|
@gtsonevv Oh, I missed your message, sorry for the delay. I believe you are in a better position to judge if it is ready to merge. To be honest, I have never used secp256k1 keys on NEAR. |
Motivation
Rebased version of #810
Description
Adds support for secp256k1 curve
Checklist