Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Check for Existing Beneficiary in Account Deletion & Repair CI #1009

Merged
merged 9 commits into from
Aug 4, 2022
Merged

Fix Check for Existing Beneficiary in Account Deletion & Repair CI #1009

merged 9 commits into from
Aug 4, 2022

Conversation

idea404
Copy link
Contributor

@idea404 idea404 commented Aug 3, 2022

This PR seeks to address the following two unaddressed subjects from #999:

  1. The conditional check during deleteAccount() now ultimately performs a view_account RPC call instead of searching for keys to determine whether a ben. account exists
  2. The test bash script is now fixed (allowing CI to pass) as deleting an account now requires user confirmation

@idea404 idea404 requested a review from volovyks August 3, 2022 17:30
@idea404 idea404 added enhancement New feature or request bug Something isn't working labels Aug 3, 2022
@volovyks volovyks merged commit e0ffe89 into master Aug 4, 2022
@idea404 idea404 deleted the fix-account-exist-check branch August 5, 2022 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@volovyks volovyks volovyks approved these changes

Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@idea404 @volovyks