generate function for asking id #581
Conversation
|
It keeps asking me the same question after I say "no, thank you" by typing n
|
|
I will fix this, thanks |
|
The tests seem to be failing as it's waiting for a response on this new prompt:
|
|
I see, I will fix the test, too. Thanks |
|
Sorry, I hate to keep adding comments, but I'm trying all the different ways. |
|
Unfortunately I cannot see Mixpanel because of a bug on their end, but I've filed a ticket. I think as long as the most recent comment is addressed and it's showing the person's accountId in Mixpanel, good to go! |
|
Thank you so much for testing and reviewing for me. |
|
|
||
| const askForId = async (options) => { | ||
| const shellSettings = settings.getShellSettings(); | ||
| if(shouldTrackID(shellSettings)){ |
There was a problem hiding this comment.
this is when the answer is 'Y' or 'y'
| mixpanel.alias(options.accountId, id), | ||
| mixpanel.people.set_once({account_id: options.accountId}) | ||
| ]); | ||
| }else if(shouldNOTTrackID(shellSettings)){ |
There was a problem hiding this comment.
this is when answer is 'N' or 'n'
| }else if(shouldNOTTrackID(shellSettings)){ | ||
| return; | ||
| } | ||
| else{ |
There was a problem hiding this comment.
This is first time to ask for that
|
Would you mind check where I point out again? Also, you can check the |
# Conflicts: # commands/generate-key.js
* generate function for asking id * asking with more commands * change message * fix issue for asking repeatly * update test * fix identity setting * change config * change back Co-authored-by: Mike Purvis <mikedotexe@gmail.com>
This reverts commit 6a71513.
generate asking question askForId to ask user whether okay to expose their account id when typing account id with command. This is for mixpanel project of identity management
change config 'default' with 'testnet'