dev-deploy usage restricted on mainnet #714
Conversation
commands/dev-deploy.js
Outdated
| @@ -36,6 +36,10 @@ module.exports = { | |||
| }; | |||
|
|
|||
| async function devDeploy(options) { | |||
| const currentNetwork = options.networkId; | |||
There was a problem hiding this comment.
Better test for mainnet specifically, betanet should support dev-deploy for example
There was a problem hiding this comment.
@vgrichina
Yes, I thought the same, but it does not work on betanet, and dev-deploy docs are explicitly targeting testnet.
There was a problem hiding this comment.
@volovyk-s why it doesn't work on betanet, what does happen?
There was a problem hiding this comment.
@vgrichina It throws an error:
`BadRequestError: Error: {"index":0,"account_id":"dev-1618909283091-6810991","predecessor_id":"betanet","registrar_account_id":"near","kind":{"account_id":"dev-1618909283091-6810991","registrar_account_id":"near","predecessor_id":"betanet"}}
According to @frol dev-deploy relies on wallet helper to distribute tokens for newly crated accounts. Probably it's not working on betanet.
`
There was a problem hiding this comment.
@volovyk-s so this seems a betanet helper misconfiguration issue that we need to fix
There was a problem hiding this comment.
That is odd! Is testnet still misconfigured allowing non-suffixed account ids? cc @bowenwang1996
There was a problem hiding this comment.
@frol why misconfigured? AFAIK even mainnet allows to create arbitrary account IDs if they are at least 32 characters long.
For example https://explorer.near.org/accounts/mikemikemikemikemikemikemikemike
There was a problem hiding this comment.
@frol where this configuration is? Who is responsible for it?
There was a problem hiding this comment.
Oh, I thought the account id is going to be shorter than 32 characters, so it depends on how big the randomNumber is then.
There was a problem hiding this comment.
@vgrichina @frol I have increased dev acc length.
|
Yes, this is why I have changed the length of the acc. |
closes #657