Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amount option renamed to deposit (with alias) #765

Merged
merged 4 commits into from
May 21, 2021
Merged

Conversation

volovyks
Copy link
Collaborator

I think that deposit is a better word for a deposit :)

Options list was out of date in README

off top: probably we should delete dead EVM commands in the next release, so basically we can do that in the next PR

Copy link
Contributor

@mehtaphysical mehtaphysical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just one suggestion

commands/call.js Outdated Show resolved Hide resolved
Co-authored-by: Ryan Mehta <ryan.mehta@gmail.com>
Copy link
Contributor

@thisisjoshford thisisjoshford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let me know when you merge and I'll update docs :)

@volovyks volovyks merged commit 1b25e16 into master May 21, 2021
@thisisjoshford thisisjoshford deleted the amount-deposit branch May 21, 2021 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants