This repository has been archived by the owner on Oct 4, 2024. It is now read-only.
chore: Remove requirement for specifying accountId for js view #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Same situation as in #984 |
|
this one's a little different, since this is due to NAJ requiring an accountId/account object to send a view function call. Specifying the accountId here isn't needed at all in the CLI so making it optional to not create a breaking change |
BenKurrek
approved these changes
May 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this forces people to specify the signer for
near js view, so removed the requirement and have the signer be whatever. This isn't really even signing anything, just an oddity ofnear-api-jsrequiring an account-id to create an account, to then make a view call