Funded account with recovery code (lock fix) #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…age sites to use the new factory appropriately
…not already exist on-chain when someone calls the create endpoint
… in cases where the SQL record was already created by a prior action (happens during initial creation using SMS or email recovery methods)
MaximusHaximus
changed the title
Patrick1904
approved these changes
Jul 1, 2021
This was referenced Jul 1, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix for near/near-wallet#1752 - which is only live on staging & testnet currently.
fundedAccountNeedsDepositset totrue, because those recovery methods create an account record in SQL before any post to/fundedAccountis done, but the existing logic in/fundedAccountassumed it would be the creator of the account./fundedAccountroute throw an error if someone hits it with an accountID that already exists, by leveraging existing middleware namedcheckAccountDoesNotExistcheckAccountDoesNotExistto be a factory function,createCheckAccountDoesNotExistMiddleware()so that we could re-use this middleware with routes that don't have the account id inrequest.body.accountId- this was needed to share this logic on/fundedAccount, which receives the argument asnewAccountId.