-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add debug, error logs for push notifications and update the service-worker's scope #1119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
charleslavon
force-pushed
the
default_scope
branch
from
April 17, 2024 16:03
160718d
to
80276f5
Compare
charleslavon
added
the
ignore-for-release
Use when a PR's description is should not be included in the changelog
label
Apr 17, 2024
charleslavon
changed the title
test the impact of using the default scope on the notifications service worker
Set the push notification worker to have a default scope of it's folder path
Apr 17, 2024
charleslavon
force-pushed
the
default_scope
branch
from
April 17, 2024 20:17
80276f5
to
2236039
Compare
…cations service worker" This reverts commit 2236039.
…e notifications service worker"" This reverts commit fcf8923.
shelegdmitriy
approved these changes
Apr 17, 2024
This reverts commit 0597d68.
charleslavon
changed the title
Set the push notification worker to have a default scope of it's folder path
Add debug, error logs for push notifications and update the servier-worker's scope
Apr 18, 2024
charleslavon
changed the title
Add debug, error logs for push notifications and update the servier-worker's scope
Add debug, error logs for push notifications and update the service-worker's scope
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Areas for additional improvement
read/delivery receipts
or error logging.