refactor: Resolves #42 replace anyhow with LakeError enum (thiserror) #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khorolets
requested review from
gabehamilton,
pkudinov,
telezhnaya,
eduohe,
morgsmccauley and
roshaans
telezhnaya
approved these changes
Apr 27, 2023
morgsmccauley
approved these changes
Apr 27, 2023
@telezhnaya the motive is described in #42 |
khorolets
added a commit
that referenced
this pull request
Apr 28, 2023
khorolets
added a commit
that referenced
this pull request
Apr 28, 2023
khorolets
added a commit
that referenced
this pull request
Jun 6, 2023
khorolets
added a commit
that referenced
this pull request
Jun 6, 2023
* feat: NEAR Lake Helper (high-level Lake Framework) (#51) * feat: NEAR Lake Helper (high-level Lake Framework) * cover all top-level primitives * Update changelog * Add getters to fields in primitives, update the required function, change Event structure * chore: Closes #61: Changes made to the lib should be picked to 0.8.0 * fix(tests): Resolved #60: Fix failing doc tests (#66) * fix(tests): Resolved #60: Fix failing doc tests * fix: add proper code annotations where possible * feat(primitives): Add support for DelegateAction (NEP-366) + LEP-002 (Focus on action and Events) (#67) * feat(primitives): Add support for DelegateAction (NEP-336) * Refactor the structures completely (LEP-002) * (examples) Address review suggestions * remove refactoring commented leftovers * (primitives) Address review suggestion, optimize the structure, do some renaming * Return iterators from methods instead of clone, improve return types, handle tx actions * add todo for later to create dedicated structures for possible errors of Failure ExecutionStatus * DelegateAction struct, split receipts file * remove commented code * expose delegate_actions mod * feat: Expose concurrency parameter to the Lake structure (and builder) (#69) * feat: LEP-001 Introduce Lake Context (#68) * feat: Implement LEP-001 (Context) * clean up Lake impl to reuse code * Update docstrings * refactor: Resolves #42 replace anyhow with LakeError enum (thiserror) (#70) * fix: typo in README * fix: CHANGELOG typos and bring back the concurrency usage lost during merging * feat: ParentTransactionCache context and example (#74) * feat: ParentTransactionCache context and example * Update README for ParentTransactionCache about advanced usage * refactor: Add LakeContext derive and introduce a concept of LakeContext with calls before and after user function * Update lake-parent-transaction-cache/README.md Co-authored-by: Morgan McCauley <morgan@mccauley.co.nz> * address review suggestion rename field accounts_id -> account_ids * add comments to the example, add READMEs, drop accidental artifact * Update documentation, add docs about the LakeContext * Add ParentTransactionCache to the Lake Framework README * refactor Lake::run method to drop code duplication --------- Co-authored-by: Morgan McCauley <morgan@mccauley.co.nz> * docs: Lake Primitives documentation added (#75) * feat: ParentTransactionCache context and example * Update documentation, add docs about the LakeContext * docs: Lake Primitives documentation added * chore: Upgrade near primitives to 0.17.0 version (#77) * chore: Prepare 0.8.0-beta.1 release (#78) * chore: Prepare 0.8.0-beta.1 release * Change to use CUSTOM_GITHUB_TOKEN and add a link to the workflow for the reasoning * Setup versioning and add release-plz.toml * Drop the release-plz job limitation on the CI job * Add missing versions to the changelog * Add 0.7.x branch to the CI --------- Co-authored-by: Morgan McCauley <morgan@mccauley.co.nz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR finishes the work regarding #42 for 0.8.8 (https://github.com/near/near-lake-framework-rs/milestone/3)
LakeErrorthat includes all possible errors from the libraryanyhowusage withLakeErrorAttention! This PR's base branch is set to this PR #68 so it's better to merge this one before that.