fix: Shard IDs is mixed-up leading to shard filenames to be incorrect #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #118
nearcore-2.4.0version with a cherry-picked commit that fixes NEAR Indexer Framework and makes NEAR Lake Indexer depend on that (until the fix is included in the actual release)Expected effect
Once deployed, we expect NEAR Lake to stop writing incorrect data.
Next steps
Once released and deployed, we must fix the incorrect data saved in the NEAR Lake buckets. For this purpose, we'd need to develop some ad-hoc script to narrow the reindex period down and then arrange the reindex process.