Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup fails witn Node v16.6.0 #15

Closed
volovyks opened this issue May 10, 2022 · 4 comments · Fixed by #255
Closed

Rollup fails witn Node v16.6.0 #15

volovyks opened this issue May 10, 2022 · 4 comments · Fixed by #255
Assignees
Labels
bug Something isn't working T-dev-tools v0.7

Comments

@volovyks
Copy link
Collaborator

volovyks commented May 10, 2022

We should understand why this is happening and fix the bug or set supported versions of Node. Works fine with Node v16.14.2

@ailisp
Copy link
Member

ailisp commented Jul 20, 2022

set supported versions of Node sounds good for now

@ailisp ailisp added the bug Something isn't working label Aug 22, 2022
@ailisp ailisp added the v0.7 label Sep 23, 2022
@Olyno
Copy link
Contributor

Olyno commented Sep 23, 2022

Hi 👋🏻 Do you have more details about this problem? Such as logs, or error messages?

@volovyks
Copy link
Collaborator Author

@Olyno not at the moment, but you can set node 16.6.0 with NVM and tests it.
I think we should follow Bo's advice and add the list of supported node versions to package.json.
Unit tests for all major node versions since v14 can be helpful. (But let's run build on 1 contract only + 1 test, because it will take forever otherwise).

@Olyno
Copy link
Contributor

Olyno commented Oct 5, 2022

I created a PR to specify the compatible Node versions as suggested. I got details about the Node 16.6.0 problem, available here: babel/babel#15015 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working T-dev-tools v0.7
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants