Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: node 16.6.0 issue #255

Merged
merged 2 commits into from
Oct 11, 2022
Merged

fix: node 16.6.0 issue #255

merged 2 commits into from
Oct 11, 2022

Conversation

Olyno
Copy link
Contributor

@Olyno Olyno commented Oct 5, 2022

Description

This pull request should avoid Rollup to fail with Node 16.6.0. You can have details about this issue here: babel/babel#15015 (comment)

Related issue

This closes #15.

@Olyno Olyno requested review from ailisp and volovyks as code owners October 5, 2022 15:56
@ailisp
Copy link
Member

ailisp commented Oct 10, 2022

Thanks! Do you have test it with some versions after and before 16.6.0? I suspect not only just 16.6.0 not work. Let's try testing a few of them on CI

Copy link
Member

@ailisp ailisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve to run ci

@Olyno
Copy link
Contributor Author

Olyno commented Oct 10, 2022

I tried a few more versions, and I didn't find any anomalies. It will be a bit complicated to test each version one by one. Could I recommend adjusting the versions according to the users' feedback?

@ailisp
Copy link
Member

ailisp commented Oct 10, 2022

@Olyno That's reasonable! Have you tested 16.5.0, 16.7.0, latest 17.x and latest 18.x?

@Olyno
Copy link
Contributor Author

Olyno commented Oct 10, 2022

I just tried the versions you asked for, and they all seem to work fine.

Should we add a security layer by adding a build worflow for these versions? By using Github actions, we could reduce the cases of incompatibility @ailisp

Copy link
Collaborator

@volovyks volovyks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
@Olyno I think that is a good idea. Let's add GitHub actions matrix with all major supported Node versions. But please, let's make it a separate job and run only 1 build and 1 test run because it will take forever to be completed.

@volovyks volovyks merged commit 513d8ab into near:develop Oct 11, 2022
@Olyno Olyno deleted the fix/node16 branch October 11, 2022 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rollup fails witn Node v16.6.0
3 participants