Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch APIs of internal collection functions to indicate private #83

Closed
austinabell opened this issue Jun 3, 2022 · 0 comments · Fixed by #179
Closed

Switch APIs of internal collection functions to indicate private #83

austinabell opened this issue Jun 3, 2022 · 0 comments · Fixed by #179
Assignees

Comments

@austinabell
Copy link
Contributor

austinabell commented Jun 3, 2022

Not sure what the convention is for obfuscating the functions from developers, but functions like serializeIndex, deserializeIndex should be more clear that they shouldn't be used.

I don't think there is any reason why they need to be exposed so either moving them out of the class so they aren't exposed or prefixing with _ or internal should probably be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants