make UnorderedMap and Set helper methods private #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinabell
reviewed
Aug 17, 2022
src/collections/unordered-map.ts
Outdated
Comment on lines
43
to
58
| private serializeIndex(index: number): Bytes { | ||
| let data = new Uint32Array([index]); | ||
| let array = new Uint8Array(data.buffer); | ||
| return u8ArrayToBytes(array); | ||
| } | ||
|
|
||
| deserializeIndex(rawIndex: Bytes) { | ||
| private deserializeIndex(rawIndex: Bytes) { | ||
| let array = bytesToU8Array(rawIndex); | ||
| let data = new Uint32Array(array.buffer); | ||
| return data[0]; | ||
| } | ||
|
|
||
| getIndexRaw(key: Bytes): Bytes { | ||
| private getIndexRaw(key: Bytes): Bytes { | ||
| let indexLookup = this.keyIndexPrefix + JSON.stringify(key); | ||
| let indexRaw = near.storageRead(indexLookup); | ||
| return indexRaw; |
There was a problem hiding this comment.
why are these associated functions to begin with? Can't these live outside of the structure to avoid misuse (when ignoring or not using TS types)?
volovyks
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #83