Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #247 #249

Merged
merged 3 commits into from
Sep 30, 2022
Merged

Fix #247 #249

merged 3 commits into from
Sep 30, 2022

Conversation

ailisp
Copy link
Member

@ailisp ailisp commented Sep 29, 2022 •
edited
Loading

Fix #247. Main fix is here: near/quickjs#4. Extend the test to verify the fix works.

@ailisp ailisp requested a review from volovyks as a code owner September 29, 2022 07:48
@ailisp ailisp mentioned this pull request Sep 29, 2022
Closed
volovyks
volovyks approved these changes Sep 30, 2022
View reviewed changes
Copy link
Collaborator

@volovyks volovyks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great investigation on this issue!
You mentioned that the result could depend on the number itself. Should we test not just zero, but several more numbers just to be sure?

@ailisp
Copy link
Member Author

ailisp commented Sep 30, 2022

You mentioned that the result could depend on the number itself. Should we test not just zero, but several more numbers just to be sure?

I tested attached deposit 1-10 NEAR. Previously, some is correct, some is not. After the fix, all of them work, which probably can mean it fixes the wrong cases while still correct in the correct cases.

@ailisp ailisp merged commit 71f8b4f into develop Sep 30, 2022
@ailisp ailisp deleted the fix-247 branch September 30, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@volovyks volovyks volovyks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dust in attachedDeposit
2 participants
@ailisp @volovyks