Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nested and nested nested collection example #251

Merged
merged 4 commits into from
Oct 11, 2022
Merged

Conversation

ailisp
Copy link
Member

@ailisp ailisp commented Sep 30, 2022

@volovyks @petarvujovic98 @osalkanovic This is the way that I can figure out with recent enhancement in collection APIs. It's relatively intuitive, one way that work for all collections and support any number of nested collections. Of course there's more than one way of doing this now and it's possible that you come up with a better way. Please feel free to suggest or make another PR to discuss!

@ailisp ailisp requested a review from volovyks as a code owner September 30, 2022 13:30
Copy link
Collaborator

@volovyks volovyks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ailisp I have tried to come up with a better version, but looks like it is not possible with the current collections APIs. We can come back to it someday after 1.0.

@volovyks volovyks merged commit 24628dc into develop Oct 11, 2022
@ailisp ailisp deleted the nested-example branch October 11, 2022 09:00
@volovyks volovyks restored the nested-example branch October 11, 2022 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants