feat: Improve CLI output #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Transform CLI tools to TypeScript Add CLI tsconfig file and update build script Fix ESLint types resolution Change argument parser from yargs to commander Add signale logger Add verbose flag Add verbose flag recognition to near-bindgen-exporter
volovyks
reviewed
Oct 12, 2022
tsconfig.cli.json
Outdated
| @@ -0,0 +1,24 @@ | |||
| { | |||
There was a problem hiding this comment.
Why do we need 2 tsconfig files?
There was a problem hiding this comment.
@volovyks Because the target folder for the CLI output is different, we could however just leave it under the lib folder and use it from there.
There was a problem hiding this comment.
Let's experiment with it in a separate PR. Maybe it's a good idea to move /cli to /src. Build artifacts should live separately.
volovyks
reviewed
Oct 12, 2022
Remove comments Restore builder.c file Update build:cli script to change cli.js to be executable
Move CLI files to lib/cli Move builder to builder folder Change scripts for installation and fix paths in cli.js
volovyks
approved these changes
Oct 12, 2022
ailisp
approved these changes
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transform CLI tools to TypeScript
Add CLI tsconfig file and update build script
Fix ESLint types resolution
Change argument parser from yargs to commander
Add signale logger
Add verbose flag
Add verbose flag recognition to near-bindgen-exporter
Addresses #227