Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli chmod hack deleted #277

Merged
merged 2 commits into from
Nov 3, 2022
Merged

cli chmod hack deleted #277

merged 2 commits into from
Nov 3, 2022

Conversation

volovyks
Copy link
Collaborator

@volovyks volovyks commented Nov 2, 2022

No description provided.

@volovyks volovyks requested a review from ailisp as a code owner November 2, 2022 18:06
@volovyks volovyks marked this pull request as draft November 2, 2022 18:06
@volovyks volovyks marked this pull request as ready for review November 2, 2022 18:51
ailisp
ailisp reviewed Nov 3, 2022
View reviewed changes
Copy link
Member

@ailisp ailisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will the packaged near-sdk-js still installing near-sdk-js as executable? Is that because npm/yarn will do that?

@volovyks
Copy link
Collaborator Author

volovyks commented Nov 3, 2022

@ailisp I checked the docs on this, the only thing we need to do is to add it to bin in package.json. TS CLI file does not need to be 755, and the JS CLI file is already 755 and it stays 755 after we make changes to TS one and yarn build.
chmod works only on UNIX systems, so it's better if we will not use it.

ailisp
ailisp approved these changes Nov 3, 2022
View reviewed changes
Copy link
Member

@ailisp ailisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ailisp ailisp merged commit b1396bc into develop Nov 3, 2022
@ailisp ailisp deleted the serhii/chmod-deletion branch November 3, 2022 08:11
waynenilsen pushed a commit to waynenilsen/near-sdk-js that referenced this pull request Nov 10, 2022
@volovyks @waynenilsen
cli chmod hack deleted (near#277)
d2b1d92 
* cli chmod hack deleted

* cli chmod 755
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ailisp ailisp ailisp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@volovyks @ailisp