Use TS ? to replace option in nft standard interface #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@volovyks Ready for review. workspace starts to hit "key not found" error again, and pass on retrying. Not sure it worth investigaing. |
volovyks
reviewed
Nov 22, 2022
| this.base_uri = null; | ||
| this.reference = null; | ||
| this.reference_hash = null; | ||
| this.icon = undefined; |
There was a problem hiding this comment.
I think there is no point to set it to undefined. It's undefined by default.
There was a problem hiding this comment.
Good point! In rust, json with these field are returned, with null as value. so I'll change it to null.
| @@ -45,10 +44,10 @@ export class NFTContractMetadata { | |||
| assert_valid() { | |||
| assert(this.spec == NFT_METADATA_SPEC, "Spec is not NFT metadata"); | |||
| assert( | |||
| (this.reference != null) == (this.reference_hash != null), | |||
| (this.reference !== undefined) == (this.reference_hash !== undefined), | |||
There was a problem hiding this comment.
What will happen if it is null? Should we check for it?
| "Reference and reference hash must be present" | ||
| ); | ||
| if (this.reference_hash != null) { | ||
| if (this.reference_hash !== undefined) { |
There was a problem hiding this comment.
Same here and in other places.
volovyks
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #289