Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build script when there is space in project path #340

Merged
merged 3 commits into from
Feb 6, 2023
Merged

Fix build script when there is space in project path #340

merged 3 commits into from
Feb 6, 2023

Conversation

ailisp
Copy link
Member

@ailisp ailisp commented Feb 3, 2023

Fix #248 , main problem is fixed in near/binaryen wasi-stub wrapper script, where it didn't handle space in path

@ailisp ailisp requested a review from volovyks as a code owner February 3, 2023 07:52
volovyks
volovyks approved these changes Feb 3, 2023
View reviewed changes
Copy link
Collaborator

@volovyks volovyks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

@ailisp ailisp merged commit d0dce58 into develop Feb 6, 2023
@ailisp ailisp deleted the fix-space-in-dir branch February 6, 2023 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@volovyks volovyks volovyks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build fails when there's a space in directory name
2 participants
@ailisp @volovyks