Remove alpha warning #345
Merged
Remove alpha warning #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we have done testing regarding arithmetic correctness in https://github.com/near/libbf-test, in the same test suite for the C++'s boost.multiprecision library. We consider the JavaScript runtime is reasonably secure for DApps and even financial DApps. The alpha warning is therefore removed. The contributing parts at beginning of the doc is duplicate to the `## Contributing` section later, so it's also removed
Closed
volovyks
approved these changes
Feb 23, 2023
|
Good point! I checked the quickjs commit in this PR is the same as we used in near-sdk-js and it's ahead of the upstream quickjs, so it is fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we have done testing regarding arithmetic correctness in https://github.com/near/libbf-test, in the same test suite for the C++'s boost.multiprecision library. We consider the JavaScript runtime is reasonably secure for DApps and even financial DApps. The project is therefore moving forward from the alpha stage.
This doesn't mean a formal audit or comprehensive testing of entire quickjs runtime, but it is an due diligence effort to ensure the most critical part: value-related calculation is well-tested. We will continue doing ourselves, seeking professional audit team and supporting community builders to increase the reliability and security of near-sdk-js.
The contributing parts at beginning of the doc is duplicate to the
## Contributingsection later, so it's also removed.This PR closes #312.