Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update doc #398

Merged
merged 4 commits into from
Jun 6, 2024
Merged

chore: update doc #398

merged 4 commits into from
Jun 6, 2024

Conversation

fospring
Copy link
Contributor

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • Commit messages follow the conventional commits spec
  • If this is a code change: I have written unit tests.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Test Plan

Related issues/PRs

@fospring fospring requested review from ailisp and volovyks as code owners May 30, 2024 10:30
ailisp
ailisp reviewed May 31, 2024
View reviewed changes
near-sdk-js@2.0.0-diff-1.0.0.md Outdated
@@ -0,0 +1,188 @@
# Breaking features from SDK 2.0.0 diff from 1.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's link this documentation from main readme

Copy link
Contributor Author

@fospring fospring Jun 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, added link from README.md

ailisp
ailisp reviewed May 31, 2024
View reviewed changes
near-sdk-js@2.0.0-diff-1.0.0.md Outdated
}
}
```
In [near-sdk-js 2.0.0](https://www.npmjs.com/package/near-sdk-js/v/2.0.0-0) With schemas, this is no longer needed, as the SDK can correctly infer how to decode the Nested Collections:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also update this to 2.0.0

Copy link
Contributor Author

@fospring fospring Jun 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok,updated

@fospring fospring force-pushed the chore/update-doc branch from 4148f44 to 25e6889 Compare June 4, 2024 03:52
@ailisp ailisp merged commit 70722d1 into near:develop Jun 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ailisp ailisp ailisp approved these changes

@volovyks volovyks Awaiting requested review from volovyks volovyks is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fospring @ailisp