chore: adjust raw near call to newer near js calls in README
#54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
May 20, 2022 15:50
ailisp
reviewed
May 23, 2022
| node encode_call.js <your-account> <method-name> <args> | ||
|
|
||
| </p> | ||
| </details> |
There was a problem hiding this comment.
This content is correct, but I would suggest to only keep the awesome near js ... command here, to make getting started short and straightforward to learn. The raw CLI calls, will be interesting when user get more familiar, which can be put in the reference or advanced usage part.
ailisp
reviewed
May 23, 2022
| ``` | ||
|
|
||
| <details> | ||
| <summary><strong>Example output</strong></summary> |
There was a problem hiding this comment.
Nice I like the splitted example output! Much cleaner than before
ailisp
reviewed
May 23, 2022
| near call jsvm.test.near call_js_contract --accountId <accountID> --base64 --args $(node encode_call.js <contract-account-id> <function-name> '[<parameter>]') --deposit 0.1 | ||
| ``` | ||
|
|
||
| or with t<details> |
There was a problem hiding this comment.
Also I suggest to drop the raw commands in these example READMEs. I think just let advanced user know about the raw command in one place?
ailisp
approved these changes
May 23, 2022
volovyks
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converted over most of the
near call ...intonear js ...ones. I also corrected some IDs that didn't look right, so let me know if those make sense.Also, hid the output in html tags so that the README isn't too long and cognitive load becomes a problem when a new user comes to read it