-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add clean state example #61
Conversation
# Clean state contract in JavaScript | ||
|
||
This is an equivalent JavaScript implementation of the clean state example. Every user can send and receive a non-fungible token. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to add a short instruction about how to use this contract. In summary, the steps are:
- Deploy this contract to the account where you want to clean up state
- Call the contract with known state keys to clean state. If delete all keys doesn't fit gas limit, you may need to do it a few times
- Once finished clean up state, Deploy the original contract or delete the contract code with
near js remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, PTAL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall the implementation and test is good! Docs need some update to help new developers
Co-authored-by: Bo Yao <bo@near.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
From now on we will need to add each example to the examples CI job (check .github/
folder).
@volovyk-s done! |
@volovyk-s seems like the CI has run out of space. Can we upgrade the instance? Or I guess alternatively clean up |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Hopefully this is what we are looking for but lmk if you need anything more in-depth