fix: add compiler error for using Result with init

near-sdk-macros/src/core_impl/code_generator/impl_item_method_info.rs

@@ -154,15 +154,8 @@ impl ImplItemMethodInfo {
  .to_compile_error();
  }
  ReturnType::Type(_, return_type) if utils::type_is_result(return_type) => {
- return syn::Error::new(
- return_type.span(),
- "Serializing Result<T, E> has been deprecated. Consider marking your method \
- with #[handle_result] if the second generic represents a panicable error or \
- replacing Result with another two type sum enum otherwise. If you really want \
- to keep the legacy behavior, mark the method with #[handle_result] and make \
- it return Result<Result<T, E>, near_sdk::Abort>.",
- )
- .to_compile_error();
+ return syn::Error::new(return_type.span(), RESULT_DEPRECATED_MESSAGE)
+ .to_compile_error();
  }
  ReturnType::Type(_, _) => {
  let value_ser = match result_serializer {
@@ -243,10 +236,23 @@ fn init_method_wrapper(
  return_type.span(),
  "Method marked with #[handle_result] should return Result<T, E> (where E implements FunctionError).",
  )),
+ ReturnType::Type(_, return_type) if utils::type_is_result(return_type) => {
+ Err(syn::Error::new(
+ return_type.span(),
+ RESULT_DEPRECATED_MESSAGE
+ ))
+ }
  ReturnType::Type(_, _) => Ok(quote! {
  #state_check
  let contract = #struct_type::#ident(#arg_list);
  near_sdk::env::state_write(&contract);
  }),
  }
 }
+
+static RESULT_DEPRECATED_MESSAGE: &str = "\
+Serializing Result<T, E> has been deprecated. Consider marking your method \
+with #[handle_result] if the second generic represents a panicable error or \
+replacing Result with another two type sum enum otherwise. If you really want \
+to keep the legacy behavior, mark the method with #[handle_result] and make \
+it return Result<Result<T, E>, near_sdk::Abort>.";

near-sdk-macros/src/core_impl/code_generator/item_impl_info.rs

@@ -786,6 +786,23 @@ mod tests {
  assert_eq!(expected.to_string(), actual.to_string());
  }
 
+ #[test]
+ fn init_result_without_handle_result() {
+ let impl_type: Type = syn::parse_str("Hello").unwrap();
+ let mut method: ImplItemMethod = parse_quote! {
+ #[init]
+ pub fn new() -> Result<Self, &'static str> { }
+ };
+ let method_info = ImplItemMethodInfo::new(&mut method, false, impl_type).unwrap().unwrap();
+ let actual = method_info.method_wrapper();
+ let expected = quote!(
+ compile_error! {
+ "Serializing Result<T, E> has been deprecated. Consider marking your method with #[handle_result] if the second generic represents a panicable error or replacing Result with another two type sum enum otherwise. If you really want to keep the legacy behavior, mark the method with #[handle_result] and make it return Result<Result<T, E>, near_sdk::Abort>."
+ }
+ );
+ assert_eq!(expected.to_string(), actual.to_string());
+ }
+
  #[test]
  fn handle_result_init_ignore_state() {
  let impl_type: Type = syn::parse_str("Hello").unwrap();