[Enhancement] Deprecate Fungible Token declarative macros. #1054
Conversation
| pub use self::core::FungibleTokenCore; | ||
| pub use crate::storage_management::StorageManagement; | ||
| pub use core_impl::FungibleToken; | ||
| pub use macros::*; | ||
| pub use resolver::FungibleTokenResolver; |
There was a problem hiding this comment.
Let's align on one way of importing things. I like self::, but it is not the style used before, so let's not use it now.
There was a problem hiding this comment.
There is a reason I used self there and it has to do with the fact that otherwise we get an ambiguity error. I have changed that to use the fully qualified path crate::fungible_token..
There was a problem hiding this comment.
Note, that we do use self for non_fungible_token imports. For that same reason - there is a name ambiguity problem with core.
There was a problem hiding this comment.
@ruseinov We should consider migrating all the imports to use self:: or crate:: for local imports, but it is a separate discussion.
There was a problem hiding this comment.
self is interesting for disambiguation scenarios, because the path ends up being shorter.
|
This seems to be an a good shape for another round of reviews. |
|
@ruseinov The only remaining item left is the CI. Add the offending packages to the ignore list and create a separate issue to address it in the future. |
Closes #1049