Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: upgrade syn crate from version 1 to 2 #1088

Merged
merged 14 commits into from
Oct 4, 2023
Merged

refactor: upgrade syn crate from version 1 to 2 #1088

merged 14 commits into from
Oct 4, 2023

Conversation

iho
Copy link
Contributor

@iho iho commented Sep 30, 2023

No description provided.

@iho iho marked this pull request as ready for review October 1, 2023 11:19
@iho iho marked this pull request as draft October 2, 2023 11:13
@iho
Copy link
Contributor Author

iho commented Oct 2, 2023

Hi @uint
Can you review this PR, please?

frol
frol requested changes Oct 2, 2023
View reviewed changes
Copy link
Collaborator

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, if all the tests pass, this seems safe to merge, but I still left a few comments to address before we merge this PR.

near-sdk/tests/event_tests.rs Outdated Show resolved Hide resolved
near-sdk-macros/src/core_impl/info_extractor/serializer_attr.rs Outdated Show resolved Hide resolved
near-sdk-macros/src/core_impl/info_extractor/serializer_attr.rs Outdated Show resolved Hide resolved
near-sdk-macros/src/lib.rs Outdated Show resolved Hide resolved
near-sdk-macros/src/lib.rs Outdated Show resolved Hide resolved
near-sdk-macros/src/core_impl/event/mod.rs Outdated Show resolved Hide resolved
near-sdk-macros/src/core_impl/event/mod.rs Outdated Show resolved Hide resolved
near-sdk-macros/src/core_impl/event/mod.rs Show resolved Hide resolved
near-sdk-macros/src/core_impl/event/mod.rs Show resolved Hide resolved
@iho iho marked this pull request as ready for review October 3, 2023 11:26
@frol frol changed the title chore: bump syn crate from 1 to 2 refactor: upgrade syn crate from version 1 to 2 Oct 4, 2023
@frol frol merged commit 185fd6b into near:master Oct 4, 2023
14 checks passed
@frol frol mentioned this pull request Oct 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frol frol frol approved these changes

@agostbiro agostbiro Awaiting requested review from agostbiro

@uint uint Awaiting requested review from uint

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iho @frol