[Fix] Contract source metadata compilation issue. #1118
Conversation
near-sdk-macros/src/lib.rs
Outdated
| @@ -116,6 +117,7 @@ pub fn near_bindgen(attr: TokenStream, item: TokenStream) -> TokenStream { | |||
|
|
|||
| if let Ok(input) = syn::parse::<ItemStruct>(item.clone()) { | |||
| let metadata = core_impl::contract_source_metadata_const(attr); | |||
| let metadata_impl_gen = generate_metadata_impl(&input.ident, &input.generics); | |||
There was a problem hiding this comment.
This way the generated function will only be implemented on the contract struct, but not exposed as contract methods and ABI is not generated for it. This has to be fixed and also test added as we obviously could have missed it unless I happened to spot it.
There was a problem hiding this comment.
Good catch. That indeed needs to be pushed into input instead in order to be properly processed.
I'll add a test for that and add an issue to have an automated test later that would perhaps go through all the defined methods and check if the abi is generated for them. Gotta see if this can be easily implemented, but definitely out of scope of this PR.
There was a problem hiding this comment.
- Merge contents of
near-sdk-macros/src/core_impl/contract_metadata/mod.rsinto this file - Rename this file to
contract_metadata.rs - Rename
generate_metadata_implfunction togenerate_contract_metadata_method
There was a problem hiding this comment.
This directory structure follows the same pattern as all the other traits that are being implemented via macro/codegen. I would argue that we should either convert all of them or none. I would personally find having those traits under code_generator a bit confusing.
The rename is not a problem though.
ruseinov
force-pushed
the
ru/fix/compilation-err
branch
from
4e6bbec
to
d33e537
Compare
ruseinov
force-pushed
the
ru/fix/compilation-err
branch
from
31bd6f7
to
5598578
Compare
Fixes #1117