chore: update `nearcore` crates from `0.17` -> `0.20` #1130

dj8yfo · 2024-01-12T22:41:10Z

No description provided.

dj8yfo · 2024-01-12T23:06:35Z

.github/workflows/test.yml

@@ -13,7 +13,7 @@ jobs:
    strategy:
      matrix:
        platform: [ubuntu-latest, macos-latest]
-        toolchain: [stable, 1.69.0]
+        toolchain: [stable, 1.72.1]


error[E0659]: `opentelemetry` is ambiguous --> /home/user/.cargo/registry/src/index.crates.io-6f17d22bba15001f/near-o11y-0.19.0/src/lib.rs:6:9 | 6 | pub use opentelemetry::OpenTelemetryLevel; | ^^^^^^^^^^^^^ ambiguous name | = note: ambiguous because of multiple potential import sources = note: `opentelemetry` could refer to a crate passed with `--extern` = help: use `::opentelemetry` to refer to this crate unambiguously note: `opentelemetry` could also refer to the module defined here --> /home/user/.cargo/registry/src/index.crates.io-6f17d22bba15001f/near-o11y-0.19.0/src/lib.rs:22:1 | 22 | mod opentelemetry; | ^^^^^^^^^^^^^^^^^^ = help: use `crate::opentelemetry` to refer to this module unambiguously For more information about this error, try `rustc --explain E0659`. error: could not compile `near-o11y` (lib) due to previous error

buildkite script has to be corrected https://buildkite.com/nearprotocol/near-sdk-rs/builds/5218#018d0c88-ae78-49e7-8789-577def4a19da

near-sdk/Cargo.toml

…imes-non-default`

.github/workflows/test.yml

near-sdk/src/environment/env.rs

near-sdk/src/environment/mock/external.rs

near-sdk/src/environment/mock/mocked_blockchain.rs

near-sdk/src/environment/mock/receipt.rs

near-sdk/src/promise.rs

near-sdk/src/store/unordered_set/mod.rs

near-sdk/src/test_utils/mod.rs

frol

Overall, since it is already in a compilable state, I would merge it and iterate in a separate PR.

near-sdk/src/types/public_key.rs

near-sdk/src/promise.rs

frol · 2024-01-16T17:02:22Z

near-sdk/src/environment/mock/receipt.rs

+struct GasWeightSer(u64);
+
+#[derive(Debug, Clone, serde::Serialize, PartialEq, Eq)]
+pub enum MockAction {


I am trying to understand if receipt_index is actually necessary at this level, and if the types mismatch with the blockchain is justified... @dj8yfo What is your understanding here?

@austinabell Can you shed some light here by any chance?

I can't remember the context, and I don't know about the nearcore updates. I can think about it more another time, but I wouldn't wait on my response, sorry!

frol

@dj8yfo Great job! Thanks you for pulling it out. I plan to cut 5.0.0-alpha.2 after merging this one

chore: update nearcore crates from 0.17 -> 0.19

10164c3

dj8yfo force-pushed the update_neacore_deps branch from 81bb8bc to 707c445 Compare January 12, 2024 23:05

dj8yfo commented Jan 12, 2024

View reviewed changes

dj8yfo force-pushed the update_neacore_deps branch from 707c445 to 10164c3 Compare January 12, 2024 23:32

dj8yfo commented Jan 13, 2024

View reviewed changes

near-sdk/Cargo.toml Outdated Show resolved Hide resolved

test: test nearcore crates patched versions from `nagisa/makes-runt…

22aedbf

…imes-non-default`