chore: adding abi tests #1136
Merged
chore: adding abi tests #1136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frol
requested changes
Jan 27, 2024
near-sdk-macros/src/lib.rs
Outdated
Comment on lines
647
to
648
| #[cfg(test)] | ||
| mod tests { |
There was a problem hiding this comment.
@shariffdev
- This place does not make sense for these tests. Let's move them to
near-sdk/tests/ - I would like to encourage you to consider looking into cargo-near implementation of abi extraction to avoid sh script running, etc: https://github.com/near/cargo-near/blob/48c7b48fa0f7f3b4afda447ba0b04cce3609b0a9/cargo-near/src/commands/abi_command/abi.rs#L31
ghost
marked this pull request as ready for review
|
@shariffdev Would you be able to fix the issues highlighted by CI? |
frol
approved these changes
Feb 4, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1124