Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: nep330 build info field of contract metadata #1178

Merged
merged 29 commits into from
Jun 19, 2024
Merged

feat: nep330 build info field of contract metadata #1178

merged 29 commits into from
Jun 19, 2024

Conversation

dj8yfo
Copy link
Collaborator

@dj8yfo dj8yfo commented May 3, 2024

No description provided.

@dj8yfo dj8yfo mentioned this pull request May 3, 2024
Merged
4 tasks
frol
frol requested changes Jun 5, 2024
View reviewed changes
Copy link
Collaborator

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the right direction! I have left a couple of review comments to address

near-sdk-macros/src/core_impl/contract_metadata/build_info.rs Outdated Show resolved Hide resolved
near-sdk-macros/src/core_impl/contract_metadata/build_info.rs Outdated Show resolved Hide resolved
near-sdk-macros/src/core_impl/contract_metadata/build_info.rs Outdated Show resolved Hide resolved
near-sdk-macros/src/core_impl/contract_metadata/mod.rs Outdated Show resolved Hide resolved
@frol frol mentioned this pull request Jun 5, 2024
Merged
dj8yfo pushed a commit to dj8yfo/near-sdk-rs that referenced this pull request Jun 6, 2024
review: addresses near#1178 (comment)
a34e7ef
@dj8yfo dj8yfo marked this pull request as ready for review June 17, 2024 14:44
frol
frol previously approved these changes Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now. We just need to resolve the CI errors

@frol frol merged commit 8077e9f into near:master Jun 19, 2024
15 checks passed
@frol frol mentioned this pull request Jun 19, 2024
Merged
@dj8yfo
Copy link
Collaborator Author

dj8yfo commented Jun 20, 2024 •
edited
Loading

rust-lang/rust-clippy#12967 silenced with 39baf19 , per-item annotations of #[allow(clippy::...)]
somewhat strangely do not work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frol frol frol approved these changes

@agostbiro agostbiro Awaiting requested review from agostbiro

@uint uint Awaiting requested review from uint

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dj8yfo @frol