chore: remove public visibility of b58 error variant #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matklad
approved these changes
May 12, 2021
No worries, that's what reviews are for! I guess, a useful action item here would be, before the next release, for someone to walk through the generated rustdoc documentation, to see if the API accidentlally exposes stuff it shouldn't. |
evgenykuzyakov
approved these changes
May 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out by @matklad here it's probably best if we don't expose the error variants, to make it easier to make changes without being stuck to specific impls (in this case the base 58 error).
Probably best if this comes in before the next release, sorry for overlooking exposing this!