chore: remove rlib tag from examples #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinabell
requested review from
ChaoticTempest,
evgenykuzyakov and
mikedotexe
as code owners
ChaoticTempest
approved these changes
Aug 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rlibcrate type should only be needed when using for type inference on cross contract sim tests. This removes from all others and keeps the ones used for sim tests for nowThere should probably be a better script setup to only compile it as such when running sim tests and the regular build would ignore this. Can probably use crate-type flags to do so.
Edit: I don't think there is a better way to handle this. The crate-type flag's behaviour is very undefined and cannot be relied on and I don't think would work in this example for testing. More discussion around this here rust-lang/cargo#4881. We could maybe do something hacky around modifying Cargo.toml files programmatically for the build to remove rlib, but this doesn't seem that extensible.
cc: @mikedotexe possibly the sim docs you are writing should have a note about this being needed, if we start to move away from it as a default?