Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(env): Update method name parameters in env to string equivalents #515

Merged
merged 7 commits into from
Aug 5, 2021

Conversation

austinabell
Copy link
Contributor

  • Updates the function signatures from raw bytes for method names to String
    • These method names must be utf8 so this signature will be more ergonomic and harder to misuse.

Was related to something I was working on, and decided to break apart and PR separately

This is a breaking change, so could leave out of 4.0 release (#494) but I think this is incorrect and better to change sooner than later.

HELP.md Outdated Show resolved Hide resolved
@mikedotexe
Copy link
Contributor

Interesting, any idea why we would do this the other way in the first place?

@austinabell
Copy link
Contributor Author

Interesting, any idea why we would do this the other way in the first place?

My guess, as similar from the log and panic signatures, that it was done cautiously to avoid any potential code size increases but this is not the case.

Also, going to think through alternatives and consider deprecating and creating a new function tomorrow morning, which is probably the better route than this breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants