-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement fixed length hash functions and optimize existing imlementations #646
Conversation
how about something like |
I personally am confused with this wording, because I don't see what boxed refers to here or what |
@austinabell ahh my bad, I meant to say that |
Could also suffix something like |
But aren't they both hashes though? I think |
Was just giving a benefit to using hash suffix. I'll switch to array suffix since it might be more clear :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New changes LGTM
env
hash functions (no reason to allocate if we know the length)register_len
I don't necessarily like suffixing
_hash
, but ideally this is a smooth transition to avoid hard-breaking changes if users expect aVec<u8>
over the array, even though this comes with a major version bump. Name suggestions welcome!closes #645