Implement Debug for collection types
#647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itegulov
requested review from
austinabell,
ChaoticTempest,
evgenykuzyakov and
mikedotexe
as code owners
itegulov
force-pushed
the
debug-for-collections
branch
from
4b845fc
to
eee73c0
Compare
austinabell
suggested changes
Nov 29, 2021
itegulov
force-pushed
the
debug-for-collections
branch
from
eee73c0
to
6a95c13
Compare
itegulov
force-pushed
the
debug-for-collections
branch
from
6a95c13
to
b42230d
Compare
|
@austinabell I have addressed your comments, should be better now. PTAL whenever you can. |
itegulov
force-pushed
the
debug-for-collections
branch
from
b42230d
to
21b45c8
Compare
austinabell
approved these changes
Dec 10, 2021
itegulov
force-pushed
the
debug-for-collections
branch
from
bbfd3d0
to
955cbae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #564
This PR implements
Debugtrait in a uniform fashion forUnorderedMap,UnorderedSet,LookupMap,LookupSet,TreeMap,LegacyTreeMapandLazyOption.Where possible I tried to provide a human-readable list of elements as if it was just a plain Rust collection, but for some of them (
LookupMapandLookupSet) it is impossible to do by design, so I think the best we can do is to show the known internal stuff. Implementations forTreeMapandLegacyTreeMapwere actually already present, I just had to move them outside of test scope. I made one compromise in tests: in order not to complicate the test logic too much, most of them assume that the values/pairs are going to be displayed in the order of their insertion.Also, this is just a side thought, but while implementing the traits I noticed that we could split the implementations for
UnorderedSet,UnorderedMapand others into two separate set of functions whenKandVare eitherBorshSerializeorBorshDeserialize(the way it is done in Vector: see [1], [2]).