feat(contract-standards): add events to FT contract standard #723
Conversation
There was a problem hiding this comment.
Looks pretty straightforward to me, but I'll leave it to @austinabell to have the final say since he might point out some serialization stuff I might not know of
| @@ -7,17 +7,17 @@ | |||
| //! This is an extension of the events format (nep-297): | |||
| //! <https://github.com/near/NEPs/blob/master/specs/Standards/EventsFormat.md> | |||
| //! | |||
| //! The three events in this standard are [`NftMintData`], [`NftTransferData`], and [`NftBurnData`]. | |||
| //! The three events in this standard are [`NftMint`], [`NftTransfer`], and [`NftBurn`]. | |||
There was a problem hiding this comment.
Nice, thanks for the catching this!
|
Hey @frol and/or @telezhnaya I should have pinged you guys to make sure this all matches up with what gets picked up by the indexer. Do you guys mind having a quick look before I release this? |
|
@austinabell Sorry for the delay. This implementation is compatible with the NEP, and I have even checked how it works with the FT example: near-examples/FT#106 |
| } | ||
|
|
||
| #[test] | ||
| fn nft_transfers() { |
There was a problem hiding this comment.
nit: it should be tf_transfers
| } | ||
|
|
||
| #[test] | ||
| fn nft_burns() { |
There was a problem hiding this comment.
Oh it's merged 😅 I just noticed that
Created PR with the fix #735
As minting and burning are not a part of FT contract standard yet, these events are not being emitted