refactor!: move VMContext type to SDK #785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the nearcore VMContext directly causes issues (see #780) so to improve and stabilize the API from changing in the future (as it has) this type is moved to SDK.
Some fields change from what they were in
3.x, but toward what is used in the SDK now so the migration should be simpleThe same could be done with
VMConfigbut that type has all primitive types and is rarely configured specifically so I've kept that change separate from this. Possibly worth opening an issue to migrate over, but would love to hear others' opinions if this should be done.