refactor: optimize read_register to read to non-zeroed buffer #804
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed need to zero out the buffer before writing to it, seems it would be an impactful optimization.
The only opinionated point is if conversion from u64 to usize (u32 in wasm32) should be checked or not. The maximum buffer size in configs in the runtime is less than
u32::MAX
but there doesn't seem to be any blockers from this changing with a custom config -- potentially this should be unchecked for a trivial optimization in code size? The only issue is that there is UB if the register length is >u32::MAX
because the buffer created wouldn't be large enough and memory would be written outside of the buffer. cc @matklad will there be any guarantee that the max will always be <u32::MAX
?