chore: update to 0.13.0 nearcore crates #820
Conversation
Needed to retain functionality for unit testing within the SDK near/near-sdk-rs#820 is the matching PR to the SDK (and other changes needed when updating for reference)
| fn pub_key_conversion(key: &VmPublicKey) -> PublicKey { | ||
| // Hack by serializing and deserializing the key. This format should be consistent. | ||
| String::from(key).parse().unwrap() | ||
| } |
There was a problem hiding this comment.
feels like this conversion could also fall into the trap of semantics changing from under us if near_crypto::PublicKey string conversion ever changes, so a test might be worthy. This isn't too important though since this is only gonna be in unit tests, so leaving this one up to you if you wanna add
| #[allow(dead_code)] | ||
| #[cfg(test)] | ||
| pub(crate) static mut NEXT_TRIE_OBJECT_INDEX: u64 = 0; | ||
| /// Get next id of the object stored on trie. | ||
| #[allow(dead_code)] | ||
| #[cfg(test)] |
There was a problem hiding this comment.
hmm, since this is the test_utils module don't we want to just expand further and say the whole module is under #[cfg(test)] instead?
There was a problem hiding this comment.
no, because these are annotated with this because they are just used within the crate, where the others are used because they are used externally (you can't use things marked with cfg(test) externally
| PrimitivesAction::DeleteKey(k) => { | ||
| VmAction::DeleteKey { public_key: pub_key_conversion(&k.public_key) } | ||
| } | ||
| PrimitivesAction::DeleteAccount(a) => { | ||
| VmAction::DeleteAccount { beneficiary_id: a.beneficiary_id.parse().unwrap() } | ||
| } |
There was a problem hiding this comment.
Very small nit: any reason why you didn't inline these like you have done with others above? Sorry for nitpicking, this is just triggering my OCD :)
There was a problem hiding this comment.
it's just default formatting, the line is too long and it pushes it like this
WIP since the crates haven't been released, opening PR for visibility and for input as a few things had to change:
receipt_indices, and addednon_exhaustiveoutcomefunction on theMockedBlockchaincreated_receiptsandlogs(nothing too breaking)Most importantly, this change comes with the functionality of having the correct
promise_batch_action_function_call_weightimplementation by using the new protocol feature