Removed the not ready enum type #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It can't be generated by the runtime fixes near#796
DavidM-D
requested review from
austinabell,
ChaoticTempest and
itegulov
as code owners
austinabell
approved these changes
Nov 25, 2022
There was a problem hiding this comment.
I think this is the correct way to go as it's unclear what the semantics would even look like if this was to be handled from the application level.
Would love another opinion on this. Also, we probably want to hold this PR until we are ready to make a major version release as this is a breaking change
|
Shouldn't we also remove it from https://github.com/near/near-sdk-rs/blob/master/near-sdk/src/types/vm_types.rs#L18? |
|
Narrator: "it was not an empty commit" |
|
🤦♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can't be generated by the runtime fixes #796