Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist redux state #1756

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Persist redux state #1756

wants to merge 17 commits into from

Conversation

marcinbodnar
Copy link
Contributor

No description provided.

@render
Copy link

render bot commented May 17, 2021

@Patrick1904
Copy link
Contributor

Loading is FAST. Seems there's a minor issue with the GlobalAlert when I recover with seed phrase. For some reason I'm not able to dismiss the success alert.

@vgrichina
Copy link
Contributor

@marcinbodnar something we should take in mind is that local storage can be pretty limited

Wonder what we can do to fail gracefully if we run out of storage (ideally we should be able to drop cache but keep accounts with keys intact)

@marcinbodnar
Copy link
Contributor Author

@marcinbodnar something we should take in mind is that local storage can be pretty limited

Wonder what we can do to fail gracefully if we run out of storage (ideally we should be able to drop cache but keep accounts with keys intact)

Checked it, if redux-persist runs into QuotaExceededError error while executing setItem it stops persisting for this particular action - localStorage state stays as it was before this action. So keys and other localStorage data are safe. Instead of a pause, we can also clear whole redux-persist data, but it doesn't seem to be necessary - what do you think?

I added an additional writeFailHandler function that will pause persisting, so it will not try to setItem again (with next actions) and don't throw more errors.

@MaximusHaximus MaximusHaximus added the Blocked ⛔️ Cannot proceed until dependency is met label Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked ⛔️ Cannot proceed until dependency is met
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The user is not able to see any data before the account state is loaded
4 participants