refactor!: Reorganize exports and modules exposed #102
Conversation
workspaces/src/network/mainnet.rs
Outdated
| @@ -3,10 +3,11 @@ use std::path::PathBuf; | |||
| use async_trait::async_trait; | |||
|
|
|||
| use crate::network::Info; | |||
| use crate::network::{Account, CallExecution, NetworkClient, NetworkInfo, TopLevelAccountCreator}; | |||
| use crate::network::{NetworkClient, NetworkInfo, TopLevelAccountCreator}; | |||
| use crate::result::CallExecution; | |||
There was a problem hiding this comment.
Why is this type not exposed? It is returned by exposed functions. So if a user wants to make a function that returns the result of one of the exposed function they reference the type.
There was a problem hiding this comment.
What are you referring to? This is just a type that wraps the type returned that includes metadata.
Edit: Also confused on what you're asking. It is exposed
There was a problem hiding this comment.
Sorry I meant from the crate: https://github.com/near/workspaces-rs/pull/102/files#diff-f2509a15c16bf20cbd905fc2d19c6b77363687408bf1020327da68936ec19ef9
Account exposes CallExecutionDetails and CallExecution, but they aren't exported.
There was a problem hiding this comment.
those are exposed under the result module which we have exported via pub mod result; in lib.rs
There was a problem hiding this comment.
This moves towards some pretty clean exports! Thanks for getting this in. Also, #73 already removed StatePatcher but it's fine, we can fix the merge conflicts if there ends up becoming one
I'll try to summarize all changes:
typesdirectory (non-breaking)StatePatcherandAllowStatePatchertraits. Ideally, this came in separate PR, but didn't want to export them just to remove lateroperationsmodule. I couldn't think of a better name but these builder types need to be exported since part of the public API. Decided to include the breaking change of removing the root declaration ofFunction, but this can be re-exported if we think it should be root levelI don't think this is perfect, but moves towards exports being a little more organized for maintainability but also so that the types exposed on our public API are exported.