-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump sandbox version default for SDK change #134
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this works for Linux-x86_64, the same binary is not available for Darwin-x86_64: https://s3-us-west-1.amazonaws.com/build.nearprotocol.com/nearcore/Darwin-x86_64/1.26.0/57b6ac92b0e77deade8a6eef1a322272511aa5de/near-sandbox.tar.gz
This is the issue I was talking about the other day
UPD: It seems that the CI agrees with me :)
ah yeah of course, slipped my mind. I think I might switch to a master commit as a temp measure until these are published |
hmmm, I wonder if the
it's really hard to test GitHub Actions. A test for a test edit: https://regex101.com/r/ilwUBl/1 shows that it works, but who knows if GitHub Actions has its own form of regex since I've seen it use some special patterns before |
Nah the regex matches, not sure here. Maybe has to do with the fact that the tagged commit isn't on master? Edit: I think it might be because the regex is in |
yeah that could be it and if so, we should probably get in a fix before 1.26 complete rolls out |
Not sure though, actions docs are inconsistent, but can see https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-including-branches-and-tags shows no Not an immediate solution. Can we update this to unblock and then fix this and update to stable later? Protocol change is being released in a couple weeks and don't want to block near/near-sdk-rs#742 / 4.0 stable |
yeah let's just roll this one in. We were previously using a non-stable commit too. We can fix the regex in the meantime, so feel free to merge this one in |
commit is
1.26.0-rc.2
for now -- tested it works against near/near-sdk-rs#742